> On July 17, 2017, 5:55 p.m., Joseph Wu wrote: > > docs/monitoring.md > > Lines 1258-1261 (patched) > > <https://reviews.apache.org/r/60791/diff/2/?file=1776299#file1776299line1258> > > > > Perhaps mention that this value is constant over the life of a single > > fetcher.
Done. > On July 17, 2017, 5:55 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher_process.hpp > > Lines 138-141 (original), 139-142 (patched) > > <https://reviews.apache.org/r/60791/diff/2/?file=1776301#file1776301line139> > > > > This method appears to be un-used and unimplemented. So you might want > > to remove it in a separate patch. Good catch, posted [r/60791](//reviews.apache.org/r/60791/). > On July 17, 2017, 5:55 p.m., Joseph Wu wrote: > > src/tests/fetcher_cache_tests.cpp > > Lines 287-291 (patched) > > <https://reviews.apache.org/r/60791/diff/2/?file=1776302#file1776302line287> > > > > Might have to be careful with this comparison. Metrics output numbers > > with `double` precision. I updated the metric to show fractional MB and used `EXPECT_DOUBLE_EQ` in the tests. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/#review180702 ----------------------------------------------------------- On July 17, 2017, 6:01 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60791/ > ----------------------------------------------------------- > > (Updated July 17, 2017, 6:01 a.m.) > > > Review request for mesos, Joseph Wu and Jiang Yan Xu. > > > Bugs: MESOS-7782 > https://issues.apache.org/jira/browse/MESOS-7782 > > > Repository: mesos > > > Description > ------- > > Add fetcher metrics to track the (constant) size of the cache size > and the (varying) amount of cache space use. The cache size is > published as `containerizer/fetcher/cache_size_total` and the used > space is `containerizer/fetcher/cache_size_used`. Both of these > metrics are in MB to be consistent with other disk space metrics. > > > Diffs > ----- > > docs/monitoring.md 38b8093ef683b5de65cbfa5330a6bbd1c9e10f12 > src/slave/containerizer/fetcher.cpp > 6a664e0657a19d27afac98fd5298d6a18aabe43f > src/slave/containerizer/fetcher_process.hpp > 0a342303574927ebfb8c60e6ce2ebe67bd8a12a3 > src/tests/fetcher_cache_tests.cpp 6e4736ea42430017ca6eff9134c1136179a4b26f > > > Diff: https://reviews.apache.org/r/60791/diff/2/ > > > Testing > ------- > > make check (Fedora 26). > > > Thanks, > > James Peach > >
