> On July 18, 2017, 9:31 p.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Lines 2886 (patched) > > <https://reviews.apache.org/r/60932/diff/1/?file=1778071#file1778071line2886> > > > > Just curious, the reason that this is a `repeated` field is there are 5 > > operations (total/read/write/sync/async)? > > Gilbert Song wrote: > Yea, per device there are 5 entries in the blkio.io_serviced file.
Got it, thanks Gilbert! > On July 18, 2017, 9:31 p.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Lines 2955 (patched) > > <https://reviews.apache.org/r/60932/diff/1/?file=1778071#file1778071line2955> > > > > If we introduce a field like this, does that mean we will fill it in > > `BlkioSubsystem::status()` since `CgroupInfo` is part of `ContainerStatus`? > > Gilbert Song wrote: > I would suggest let's remove this field and leave a TODO here, which will > be addressed when we introduce the `prepare` and `status` functions. What do > you think? So for `prepare()`, we are going to use `CgroupInfo.blkio` to do the blkio control? If so, then I am OK with it. And for `status()`, what will be the difference between it and `usage()`? Are they gonna return same statistic about blkio? - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review180794 ----------------------------------------------------------- On July 19, 2017, 5:39 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60932/ > ----------------------------------------------------------- > > (Updated July 19, 2017, 5:39 a.m.) > > > Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and > Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > Added protobuf scheme for blkio subsystem in CgroupInfo. > > > Diffs > ----- > > include/mesos/mesos.proto ab2a372184b7cfbaf7a38e90f487cba38c3e80b8 > > > Diff: https://reviews.apache.org/r/60932/diff/1/ > > > Testing > ------- > > make > > > Thanks, > > Gilbert Song > >
