> On July 20, 2017, 1:27 a.m., Qian Zhang wrote: > > include/mesos/v1/mesos.proto > > Lines 2815 (patched) > > <https://reviews.apache.org/r/60932/diff/2/?file=1780158#file1780158line2815> > > > > Why do we need this? I see `Entry.op` is a required field rather than > > an optional field, so why do we need `UNKNOWN` for a required field?
We will use `UNKNOWN` in all protobuf enums: https://issues.apache.org/jira/browse/MESOS-4997 - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181023 ----------------------------------------------------------- On July 19, 2017, 5:17 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60932/ > ----------------------------------------------------------- > > (Updated July 19, 2017, 5:17 p.m.) > > > Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and > Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > Only statistics information for blkio in protobuf. > > > Diffs > ----- > > include/mesos/mesos.proto ab2a372184b7cfbaf7a38e90f487cba38c3e80b8 > include/mesos/v1/mesos.proto 5e92e5d86023ad6edd94303fbde964bf403abf02 > > > Diff: https://reviews.apache.org/r/60932/diff/2/ > > > Testing > ------- > > make > > > Thanks, > > Gilbert Song > >
