----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61097/#review181723 -----------------------------------------------------------
3rdparty/libprocess/include/process/grpc.hpp Lines 130-133 (patched) <https://reviews.apache.org/r/61097/#comment257374> I am wondering if we should set the promise if status is OK, even if `promise->future.hasDiscard()` is true? - Jie Yu On July 28, 2017, 1:09 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61097/ > ----------------------------------------------------------- > > (Updated July 28, 2017, 1:09 a.m.) > > > Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-7810 > https://issues.apache.org/jira/browse/MESOS-7810 > > > Repository: mesos > > > Description > ------- > > A gRPC client can create a `process::grpc::client::Runtime` instance and > use its `call()` method to send an asynchronous gRPC call to `Channel` > (representing a connection to a gRPC server), and get a future waiting > for the response. The `Runtime` class maintains a `CompletionQueue` to > manage all pending asynchronous gRPC calls, and spawns a thread waiting > for any response from the `CompletionQueue`. All gRPC calls using the > same `Runtime` copy would share the same `CompletionQueue` and thread. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/grpc.hpp PRE-CREATION > 3rdparty/libprocess/src/grpc.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/61097/diff/4/ > > > Testing > ------- > > N/A > > > Thanks, > > Chun-Hung Hsiao > >
