----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61697/#review183064 -----------------------------------------------------------
Bad patch! Reviews applied: [61697] Failed command: python support/apply-reviews.py -n -r 61697 Error: Traceback (most recent call last): File "support/apply-reviews.py", line 417, in <module> main() File "support/apply-reviews.py", line 412, in main reviewboard(options) File "support/apply-reviews.py", line 402, in reviewboard apply_review(options) File "support/apply-reviews.py", line 160, in apply_review commit_patch(options) File "support/apply-reviews.py", line 268, in commit_patch shell(cmd, options['dry_run']) File "support/apply-reviews.py", line 144, in shell error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True) File "C:\Python27\lib\subprocess.py", line 168, in call return Popen(*popenargs, **kwargs).wait() File "C:\Python27\lib\subprocess.py", line 390, in __init__ errread, errwrite) File "C:\Python27\lib\subprocess.py", line 610, in _execute_child args = '{} /c "{}"'.format (comspec, args) UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 25: ordinal not in range(128) Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/239/console - Mesos Reviewbot Windows On Aug. 16, 2017, 8:17 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61697/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2017, 8:17 p.m.) > > > Review request for mesos, Alexander Rukletsov and Vinod Kone. > > > Bugs: MESOS-7861 > https://issues.apache.org/jira/browse/MESOS-7861 > > > Repository: mesos > > > Description > ------- > > This patch makes the default executor include the output of the COMMAND > (health) checks in its logs. > > > Diffs > ----- > > src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e > > > Diff: https://reviews.apache.org/r/61697/diff/2/ > > > Testing > ------- > > Manual tests. > > > Thanks, > > Gastón Kleiman > >