> On Aug. 16, 2017, 11:03 p.m., Greg Mann wrote: > > src/checks/checker_process.cpp > > Lines 143-144 (patched) > > <https://reviews.apache.org/r/61697/diff/2/?file=1798839#file1798839line143> > > > > "returns the merged stdout and stderr": is this true? Looks like you > > only use STDOUT type events here?
I'm also not sure we want to merge stdout and stderr from a check here. Maybe return a tuple here so that we can print stdout and stderr separately? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61697/#review183071 ----------------------------------------------------------- On Aug. 16, 2017, 8:17 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61697/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2017, 8:17 p.m.) > > > Review request for mesos, Alexander Rukletsov and Vinod Kone. > > > Bugs: MESOS-7861 > https://issues.apache.org/jira/browse/MESOS-7861 > > > Repository: mesos > > > Description > ------- > > This patch makes the default executor include the output of the COMMAND > (health) checks in its logs. > > > Diffs > ----- > > src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e > > > Diff: https://reviews.apache.org/r/61697/diff/2/ > > > Testing > ------- > > Manual tests. > > > Thanks, > > Gastón Kleiman > >
