----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/#review183420 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 183 (patched) <https://reviews.apache.org/r/60591/#comment259453> Usually we put the declaration of static function at the beginning of the file, and put its implemention in the end. You can take `slave.cpp` and `master.cpp` as references. src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 238-239 (patched) <https://reviews.apache.org/r/60591/#comment259433> A newline between. src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 242-246 (patched) <https://reviews.apache.org/r/60591/#comment259454> Sorry for the back and forth, is it possile for `ports.isSome()` to be false? It seems not, right? src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 243 (patched) <https://reviews.apache.org/r/60591/#comment259434> So `--resources=ports:[]` will fall into this case and the agentPorts will be an empty IntervalSet, right? And in this case, this isolator will actually work as a no-op since there is no ports we care about, right? - Qian Zhang On Aug. 22, 2017, 4:36 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60591/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2017, 4:36 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Normally, the `network/ports` isolator will kill any task that > listens on a port that it does not have resources for. However, > executors that are based on the libprocess API will always listen > on a port in the ephemeral range, and we want to make it possible > to use libprocess-based executors. > > Added the `--container_ports_watch_resources_only` option to only > kill tasks when they listen on un-allocated ports within the port > range published by the agent resources. This still prevents port > collisions between tasks, but doesn't kill them just because the > executor is listening on a port. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION > src/slave/flags.hpp 2970fea0cfac6af275a758d4bfedfe9a943c2b60 > src/slave/flags.cpp 3b02f3e909a554f15104739832ae3f252926b45f > > > Diff: https://reviews.apache.org/r/60591/diff/12/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >