----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61798/#review183462 -----------------------------------------------------------
3rdparty/stout/include/stout/exit.hpp Lines 42 (patched) <https://reviews.apache.org/r/61798/#comment259475> Shouldn't we use `CRLF` on Windows? 3rdparty/stout/include/stout/exit.hpp Lines 76 (patched) <https://reviews.apache.org/r/61798/#comment259476> Why don't you choose `stdout` vs. `stderr` based on `status` value similar to `__Exit`? - Alexander Rukletsov On Aug. 21, 2017, 8:54 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61798/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2017, 8:54 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin > Mahler, and James Peach. > > > Bugs: MESOS-7791 > https://issues.apache.org/jira/browse/MESOS-7791 > > > Repository: mesos > > > Description > ------- > > EXIT macro can't be used when async-signal safety is required. > > Currently, ABORT is used for terminating a program after both > unexpected and expected errors, when async-signal safety is required. > In case of expected errors, `abort` causes coredumps, which might be > undesirable. > > In addition, _EXIT takes variable number of arguments, thereby _EXIT > interface doesn't force users to concatenate strings, thus making its > usage more async-signal safe. > > > Diffs > ----- > > 3rdparty/stout/include/stout/exit.hpp > e5c2d3440a85ab2d2cae551ee4094cd965e38dfc > > > Diff: https://reviews.apache.org/r/61798/diff/1/ > > > Testing > ------- > > sudo make check (mac os x, fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
