> On Aug. 24, 2017, 10:59 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/exit.hpp > > Lines 39 (patched) > > <https://reviews.apache.org/r/61798/diff/2/?file=1802341#file1802341line39> > > > > Move this comment to the `_EXIT()` macro.
Done. > On Aug. 24, 2017, 10:59 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/exit.hpp > > Lines 42 (patched) > > <https://reviews.apache.org/r/61798/diff/2/?file=1802341#file1802341line42> > > > > The `EXIT` macro produces something like this: > > ``` > > E0824 15:33:17.790952 32725 main.cpp:497] EXIT with status 1: Failed to > > create a master detector: Failed to parse '///////' > > ``` > > > > It would be good to make `_EXIT` consistent, and I think you can use > > the `RAW_LOG_XXX` interfaces in `glog/raw_logging.h` for this. Fixed: `_EXIT` uses `RAW_LOG_XXX`. > On Aug. 24, 2017, 10:59 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/exit.hpp > > Lines 77 (patched) > > <https://reviews.apache.org/r/61798/diff/2/?file=1802341#file1802341line77> > > > > Lets be consistent with other code by using `::_exit(status)` here. Fixed. BTW, `std::_Exit` was introduced in c++11. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61798/#review183755 ----------------------------------------------------------- On Aug. 21, 2017, 8:54 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61798/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2017, 8:54 p.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin > Bannier, Benjamin Mahler, and James Peach. > > > Bugs: MESOS-7791 > https://issues.apache.org/jira/browse/MESOS-7791 > > > Repository: mesos > > > Description > ------- > > EXIT macro can't be used when async-signal safety is required. > > Currently, ABORT is used for terminating a program after both > unexpected and expected errors, when async-signal safety is required. > In case of expected errors, `abort` causes coredumps, which might be > undesirable. > > In addition, _EXIT supports formatted output conversion, > thereby _EXIT interface doesn't force users to concatenate strings, > thus making its usage more async-signal safe. > > > Diffs > ----- > > 3rdparty/stout/include/stout/exit.hpp > e5c2d3440a85ab2d2cae551ee4094cd965e38dfc > > > Diff: https://reviews.apache.org/r/61798/diff/3/ > > > Testing > ------- > > sudo make check (mac os x, fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
