----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61982/#review184392 -----------------------------------------------------------
Patch looks great! Reviews applied: [61920, 61921, 61982] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 30, 2017, 3:05 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61982/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2017, 3:05 a.m.) > > > Review request for mesos, Anand Mazumdar and Greg Mann. > > > Bugs: MESOS-7916 > https://issues.apache.org/jira/browse/MESOS-7916 > > > Repository: mesos > > > Description > ------- > > Update the DefaultExecutor tests to use test helpers where possible. > Also make the boilerplate initialization code consistent across tests. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 186b8333c02ba3b9257e19437c6d689761085362 > > > Diff: https://reviews.apache.org/r/61982/diff/2/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*DefaultExecutor*"` succeeds on > GNU/Linux > > > Thanks, > > Gastón Kleiman > >