----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62252/#review185814 -----------------------------------------------------------
3rdparty/libprocess/include/process/executor.hpp Lines 71 (patched) <https://reviews.apache.org/r/62252/#comment262158> Let's use the `std::enable_if<..., int>::type = 0` for now since that's what we've been trying to converge on other places. Here and below, thanks! 3rdparty/libprocess/include/process/executor.hpp Lines 87 (patched) <https://reviews.apache.org/r/62252/#comment262159> Can we also add a TODO that we ultimately want to capture `f` via a forward/move? Thanks! Can we do this? `std::bind([](F&& f) { f(); return Nothing(); }, std::forward<F>(f));` 3rdparty/libprocess/src/tests/process_tests.cpp Lines 1242 (patched) <https://reviews.apache.org/r/62252/#comment262161> Can we update the code to use `CountDownLatch` so we can use `AWAIT_READY(latch.triggered())` and also pull all the test chunks together "locally" so that it's easier to see what each piece does. Thanks! - Benjamin Hindman On Sept. 15, 2017, 3:17 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62252/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2017, 3:17 a.m.) > > > Review request for mesos, Benjamin Hindman and Benjamin Mahler. > > > Bugs: MESOS-7970 > https://issues.apache.org/jira/browse/MESOS-7970 > > > Repository: mesos > > > Description > ------- > > This patch adds a convenient interface to `process::Executor` to > asynchronously execute arbitrary functions. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/executor.hpp > cd2f2f03cba8a435f142b31def9f89a6cd61af73 > 3rdparty/libprocess/src/tests/process_tests.cpp > 82efb2f8449e4cb13620cae1a49321fc42e2db60 > > > Diff: https://reviews.apache.org/r/62252/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
