----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185939 -----------------------------------------------------------
src/resource_provider/registrar.cpp Lines 397 (patched) <https://reviews.apache.org/r/62353/#comment262280> can we try not to mix unique_ptr and Owned? I'd prefer we just use Owned for consistency (and, plus you don't have to use `.release()` below) src/tests/resource_provider_manager_tests.cpp Lines 408 (patched) <https://reviews.apache.org/r/62353/#comment262281> This does not build on WINDOWS. I suggest we use in memory storage so that we can test on windows too! - Jie Yu On Sept. 21, 2017, 7 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62353/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2017, 7 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > This patch adds an implementation of the resource provider registrar > backed by the master's registrar. With that it becomes possible to > persist resource provider manager state in a single master registrar, > but use the narrowly defined resource provider registry. > > > Diffs > ----- > > src/master/registry.proto 362a9fab946e9fb0411df2277f7f3edbadccb61a > src/resource_provider/registrar.hpp PRE-CREATION > src/resource_provider/registrar.cpp PRE-CREATION > src/tests/resource_provider_manager_tests.cpp > 3bc56b51526e9dd188423f7349e74246c3295c77 > > > Diff: https://reviews.apache.org/r/62353/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
