> On Oct. 2, 2017, 3:26 p.m., Joseph Wu wrote: > > docs/cmake.md > > Lines 42 (patched) > > <https://reviews.apache.org/r/62732/diff/1/?file=1842223#file1842223line42> > > > > Hm... The website's markdown generator is not super sophisticated, so > > I'm not sure if it will render this link correctly. > > > > It's ok to go over 80 characters on a line if it's just a URL. > > Andrew Schwartzmeyer wrote: > Ha! It better work, this is in Daring Fireball's original Markdown spec > (i.e. it's not any "flavor's" extension). I'll bug Vinod and make sure, but > it really ought to work. > > My problem with embedding URLs in the text is just that, it makes the > plaintext so much more difficult to read. But maybe that's just me.
Verified that this is no problem with the generated site. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62732/#review186899 ----------------------------------------------------------- On Oct. 5, 2017, noon, Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62732/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2017, noon) > > > Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John > Kordich, James Peach, Joseph Wu, and Li Li. > > > Bugs: MESOS-3107 > https://issues.apache.org/jira/browse/MESOS-3107 > > > Repository: mesos > > > Description > ------- > > This adds a CMake documentation file with best practices, CMake By > Example, and consolidates, fixes, and updates the CMake configuration > options to the configuration documentation. > > > Diffs > ----- > > docs/cmake-examples.md PRE-CREATION > docs/cmake.md PRE-CREATION > docs/configuration-cmake.md 1b10221429a92eddff5733e1059172b6c190b5f3 > docs/configuration.md e1fd9f75179b272c3cae3dd5be5e38f269044df5 > docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff > > > Diff: https://reviews.apache.org/r/62732/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >