----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62837/#review189673 -----------------------------------------------------------
src/tests/default_executor_tests.cpp Lines 500-508 (patched) <https://reviews.apache.org/r/62837/#comment266880> Does this still work now that the DefaultExecutor sends `TASK_STARTING` updates? src/tests/default_executor_tests.cpp Lines 537-550 (patched) <https://reviews.apache.org/r/62837/#comment266879> This should use the new `createCallKill` helper, see https://reviews.apache.org/r/63419/ for examples. - Gaston Kleiman On Oct. 8, 2017, 11:28 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62837/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2017, 11:28 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-8051 > https://issues.apache.org/jira/browse/MESOS-8051 > > > Repository: mesos > > > Description > ------- > > Added a test `DefaultExecutorTest.KillMultipleTasks`. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 2b4c643b8fb2fc8f2a5e98984ae1c267f66885d1 > > > Diff: https://reviews.apache.org/r/62837/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
