----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/#review189974 -----------------------------------------------------------
Ship it! How about the following? ``` Fixed an issue where task executor IDs are missing in the master. Due to a bug, the agent was erroneously clearing the executor ID of non-command executor's tasks before sending the `ReregisterSlaveMessage` message. This leads to the master having tasks with missing executor IDs (see MESOS-8135). Also, it turns out that the clearing of executor ID's is actually unnecessary altogether, as command executor tasks already do not have an executor ID set. Review: https://reviews.apache.org/r/63353/ ``` I think it's nice for bug fixes to clearly state what they're fixing in the summary (that's what people will see in the short log). - Benjamin Mahler On Nov. 2, 2017, 7:52 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63353/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 7:52 p.m.) > > > Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-8135 > https://issues.apache.org/jira/browse/MESOS-8135 > > > Repository: mesos > > > Description > ------- > > Previously the agent would sometimes clear the executor ID of > non-command executors before sending the `ReregisterSlaveMessage` > message. > > > Diffs > ----- > > src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 > > > Diff: https://reviews.apache.org/r/63353/diff/4/ > > > Testing > ------- > > Verified that the new test fails on GNU/Linux without the rest of the patch, > but passes with it. > > > Thanks, > > Gaston Kleiman > >
