----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/#review189410 -----------------------------------------------------------
Patch looks great! Reviews applied: [63353] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 27, 2017, 7:48 a.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63353/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2017, 7:48 a.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-8135 > https://issues.apache.org/jira/browse/MESOS-8135 > > > Repository: mesos > > > Description > ------- > > Previously the agent would sometimes clear the executor ID of > non-command executors before sending the `ReregisterSlaveMessage` > message. > > > Diffs > ----- > > src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac > src/tests/master_slave_reconciliation_tests.cpp > d5eb7ba68c5308338236879e7cb1e970a01e48e6 > > > Diff: https://reviews.apache.org/r/63353/diff/1/ > > > Testing > ------- > > Verified that the new test fails on GNU/Linux without the rest of the patch, > but passes with it. > > > Thanks, > > Gaston Kleiman > >
