> On Nov. 6, 2017, 6:47 p.m., Benjamin Bannier wrote: > > src/master/master.hpp > > Lines 925-926 (original), 935-936 (patched) > > <https://reviews.apache.org/r/63588/diff/1/?file=1882052#file1882052line935> > > > > We will need to update this comment at some point.
Done. > On Nov. 6, 2017, 6:47 p.m., Benjamin Bannier wrote: > > src/master/master.hpp > > Lines 2768 (patched) > > <https://reviews.apache.org/r/63588/diff/1/?file=1882052#file1882052line2768> > > > > I don't think we need to strictly require this. Why? I think this is necessary because it's a `Framework` method. Just an internal invariant. > On Nov. 6, 2017, 6:47 p.m., Benjamin Bannier wrote: > > src/master/master.hpp > > Lines 2889 (patched) > > <https://reviews.apache.org/r/63588/diff/1/?file=1882052#file1882052line2889> > > > > This `CHECK` is redundant with above `if` condition in this universe. This is `totalOfferedResources`, right? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63588/#review190186 ----------------------------------------------------------- On Nov. 6, 2017, 6:14 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63588/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 6:14 p.m.) > > > Review request for mesos, Benjamin Bannier and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > (This is based on https://reviews.apache.org/r/63539) > > > Diffs > ----- > > include/mesos/mesos.proto 68a5538904b601a91a40db68cebde96f74a2f160 > include/mesos/v1/mesos.proto c46cec78db63dc3714e357a954a4e7bf080485fd > src/master/master.hpp afcc2e46882e4c610e9047ab3db7b6f100d47e17 > src/master/master.cpp f349fec8b61fa424c63d77253b6ab3ded08c8cdb > src/messages/messages.proto 2fbca22e1285aa25900f5420bb4370bda6a1bb12 > > > Diff: https://reviews.apache.org/r/63588/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
