----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review190259 -----------------------------------------------------------
src/tests/default_executor_tests.cpp Line 1648 (original), 1646-1658 (patched) <https://reviews.apache.org/r/63253/#comment267561> I think rather than by wrapping the last argument to a function in an `ifdef`, this should instead just be a `const string` aobve the call to `createTask`, followed by the PowerShell command in another guard. - Andrew Schwartzmeyer On Nov. 6, 2017, 10:10 a.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63253/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 10:10 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Gaston Kleiman, John Kordich, > Joseph Wu, Li Li, and Michael Park. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Fixed changes from Gaston (git commit 772c8f5 on 10/02/2017) > for proper operation on Windows. Changed to use new URI methods > introduced as part of MESOS-6705, and used powershell on Windows > to replace "test" command on Linux. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 5078bd4d70698f5cbd14c971fcecfd58f8467a04 > > > Diff: https://reviews.apache.org/r/63253/diff/4/ > > > Testing > ------- > > Ran mesos-tests on both Windows and Linux with no errors. > > Specifically ran mesos-tests with > `--gtest_filter=MesosContainerizer/DefaultExecutorTest.*` to verify that the > modified tests ran properly. > > > Thanks, > > Jeff Coffler > >