----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review189257 -----------------------------------------------------------
src/tests/default_executor_tests.cpp Lines 1652-1653 (patched) <https://reviews.apache.org/r/63253/#comment266270> Nit: I would prefer these to be `powershell.exe` since we know the executable we're calling. src/tests/default_executor_tests.cpp Lines 1657-1658 (patched) <https://reviews.apache.org/r/63253/#comment266271> I think this could be one line now. src/tests/default_executor_tests.cpp Line 1693 (original), 1704 (patched) <https://reviews.apache.org/r/63253/#comment266272> Nit: s/coffer/coffler/g, s/powershell/PowerShell/g - Andrew Schwartzmeyer On Oct. 25, 2017, 3:17 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63253/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2017, 3:17 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Gaston Kleiman, John Kordich, > Joseph Wu, and Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Fixed changes from Gaston (git commit 772c8f5 on 10/02/2017) > for proper operation on Windows. Changed to use new URI methods > introduced as part of MESOS-6705, and used powershell on Windows > to replace "test" command on Linux. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 5078bd4d70698f5cbd14c971fcecfd58f8467a04 > > > Diff: https://reviews.apache.org/r/63253/diff/3/ > > > Testing > ------- > > Ran mesos-tests on both Windows and Linux with no errors. > > Specifically ran mesos-tests with > `--gtest_filter=MesosContainerizer/DefaultExecutorTest.*` to verify that the > modified tests ran properly. > > > Thanks, > > Jeff Coffler > >
