----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62997/#review190353 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/paths.hpp Line 55 (original), 59-60 (patched) <https://reviews.apache.org/r/62997/#comment267689> We should use `xxxPath()` consistently in this file. Could you add a TODO for refactoring? src/slave/containerizer/mesos/provisioner/provisioner.hpp Lines 170 (patched) <https://reviews.apache.org/r/62997/#comment267684> Should we add comments for removing `Option` after a deprecation cycle? src/slave/containerizer/mesos/provisioner/provisioner.cpp Lines 152-187 (patched) <https://reviews.apache.org/r/62997/#comment267697> do we really need the static functions? I think we can just do the checkpointing and read in the code since I dont see posibilities we will checkpoint twice in the near future. src/slave/containerizer/mesos/provisioner/provisioner.cpp Lines 185 (patched) <https://reviews.apache.org/r/62997/#comment267696> let's use state::checkpoint() instead. - Gilbert Song On Oct. 27, 2017, 11:03 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62997/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2017, 11:03 a.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-8079 > https://issues.apache.org/jira/browse/MESOS-8079 > > > Repository: mesos > > > Description > ------- > > Added checkpoint and recover capability for layers in provisioner. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > 689acfcbbb07f071b6195472118a7a7520a44abd > src/slave/containerizer/mesos/provisioner/paths.hpp > 466f5edab40732b0d8da4252a71fde9c2956e8e9 > src/slave/containerizer/mesos/provisioner/paths.cpp > 268dbeb4b18374ef53bc73254bf20ce6830e384f > src/slave/containerizer/mesos/provisioner/provisioner.hpp > 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 450a3b32d69d2882973a6ed4e94e169a0256056b > > > Diff: https://reviews.apache.org/r/62997/diff/3/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
