-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62997/#review190672
-----------------------------------------------------------




src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 531 (patched)
<https://reviews.apache.org/r/62997/#comment268245>

    This is the layerRootfs from store.
    
    However, I do not think we should checkpoint "layer dir" instead here, as 
it is second guessing how store manages its internal directory structure, which 
breaks the current provisioner and store abstraction.


- Zhitao Li


On Oct. 27, 2017, 6:03 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62997/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2017, 6:03 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8079
>     https://issues.apache.org/jira/browse/MESOS-8079
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added checkpoint and recover capability for layers in provisioner.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto 
> 689acfcbbb07f071b6195472118a7a7520a44abd 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 
> 466f5edab40732b0d8da4252a71fde9c2956e8e9 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 
> 268dbeb4b18374ef53bc73254bf20ce6830e384f 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 450a3b32d69d2882973a6ed4e94e169a0256056b 
> 
> 
> Diff: https://reviews.apache.org/r/62997/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Reply via email to