----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ -----------------------------------------------------------
(Updated Nov. 7, 2017, 11 p.m.) Review request for mesos, Jie Yu and Jan Schlicht. Changes ------- Addressed comment by Jie. Repository: mesos Description ------- The agent's resource provider manager sends a 'ResourceProviderMessage' when its managed resources change. This commit adds handling in the agent so that an 'UpdateSlaveMessage' is sent to the master to update the total resource available on the agent. In order to provide push-like handling of the resource provider manager's message queue, we chain recursive calls to the handler for continuous processing. Initially, processing is kicked off from 'Slave::initialize'. In this simple implementation we e.g., provide no direct way to stop processing of messages, yet, but it can be achieved by e.g., replacing the manager with a new instance (this would also require updating routes). Since the agent can only send an 'UpdateSlaveMessage' when it is registered with a master, a simple back-off of 5 s is implemented which will defer processing of a ready message should the agent not yet have registered. To facilitate logging we add a stringification function for 'ResourceProviderMessage's. This patch also adjusts a number of tests to no expect two 'UpdateSlaveMessage's. Diffs (updated) ----- src/resource_provider/message.hpp 3c7c3f2baeb726e04edd6ffbb9784699d7afe521 src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 src/slave/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1 src/tests/slave_tests.cpp f9c2e6b41bdbc54ee0d8d06a2a41c92b7a1156cc Diff: https://reviews.apache.org/r/61183/diff/23/ Changes: https://reviews.apache.org/r/61183/diff/22-23/ Testing ------- Tested on a number of platforms on internal CI. Thanks, Benjamin Bannier
