----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/#review191131 -----------------------------------------------------------
src/master/master.cpp Lines 7090-7091 (patched) <https://reviews.apache.org/r/63732/#comment268742> I don't quite follow the comments here. What do you mean by we cannot add those before? src/master/master.cpp Lines 7119 (patched) <https://reviews.apache.org/r/63732/#comment268741> Ditto. You probably want to change `addOfferOperation` to not update total resources. That means you need to goto callsites to manually apply then if it's a speculative operation. - Jie Yu On Nov. 15, 2017, 5:31 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63732/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2017, 5:31 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8207 > https://issues.apache.org/jira/browse/MESOS-8207 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.cpp 59a533940736f5cfd5ec31e0ed924f0b2ab13f9c > > > Diff: https://reviews.apache.org/r/63732/diff/2/ > > > Testing > ------- > > `make check`, still need to implement dedicated tests. > > > Thanks, > > Benjamin Bannier > >
