----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/#review191427 -----------------------------------------------------------
src/master/master.cpp Lines 7119 (patched) <https://reviews.apache.org/r/63732/#comment269243> If the LRP is not yet re-registered with the agent, we shouldn't remove the offer operation. We should only remove those operation that we know "for sure" is gone. src/master/master.cpp Lines 7126 (patched) <https://reviews.apache.org/r/63732/#comment269242> If you can `updateOfferOperation`, then allocator's state will be updated accordingly. - Jie Yu On Nov. 17, 2017, 5:26 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63732/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 5:26 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8207 > https://issues.apache.org/jira/browse/MESOS-8207 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f > > > Diff: https://reviews.apache.org/r/63732/diff/3/ > > > Testing > ------- > > `make check`, still need to implement dedicated tests. > > > Thanks, > > Benjamin Bannier > >
