----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/#review191213 -----------------------------------------------------------
The summary for this could be: > Windows: Fixed mock signal values. > > Also fixed the `WEXITSTATUS` macro to casat the exit code instead of > bit-masking it. (Maybe explain why?) 3rdparty/stout/include/stout/windows.hpp Lines 346-348 (original), 346-348 (patched) <https://reviews.apache.org/r/63859/#comment268872> We should add a link to MSDN explaining why these are now set the way they are. 3rdparty/stout/include/stout/windows.hpp Line 377 (original), 378 (patched) <https://reviews.apache.org/r/63859/#comment268871> Should this be a static cast? - Andrew Schwartzmeyer On Nov. 16, 2017, 10:17 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63859/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2017, 10:17 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and John Kordich. > > > Bugs: MESOS-7342 > https://issues.apache.org/jira/browse/MESOS-7342 > > > Repository: mesos > > > Description > ------- > > Fixed signal vals & WEXITSTATUS on Windows stout. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows.hpp > 7aa0ba72c4cc3b688ce6374b3308945ea8cb7572 > > > Diff: https://reviews.apache.org/r/63859/diff/1/ > > > Testing > ------- > > See https://reviews.apache.org/r/63862/ for test results. > > > Thanks, > > Akash Gupta > >
