----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/#review192435 -----------------------------------------------------------
3rdparty/stout/include/stout/windows.hpp Lines 343-348 (original), 343-348 (patched) <https://reviews.apache.org/r/63859/#comment270580> :/ I'd really like to fix whatever code is using these signals for logic. I feel like the defining the signals for Windows was originally a band-aid, and understand this patch didn't add them. The funny thing is that, since these values aren't defined on Windows, they could be any number so long as only the symbol is used in the rest of the code base. I think this is why this worked anyway. Akash, what bug did you run into that required correcting these? (And indeed, they now appear correct. SIGKILL is 9, SIGCONT is 18 in decimal, and SIGSTOP is 19 in decimal). 3rdparty/stout/include/stout/windows.hpp Lines 376-377 (original), 376-378 (patched) <https://reviews.apache.org/r/63859/#comment270581> I wish I had context as to why this was a bitmask originally... I'll do a git blame and see what I can dig up. - Andrew Schwartzmeyer On Nov. 27, 2017, 9:36 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63859/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2017, 9:36 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and John Kordich. > > > Bugs: MESOS-7342 > https://issues.apache.org/jira/browse/MESOS-7342 > > > Repository: mesos > > > Description > ------- > > Also fixed the WEXITSTATUS macro to cast the exit code instead of > bit-masking it, since Windows exit codes are 32 bit unsigned ints. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows.hpp > 7aa0ba72c4cc3b688ce6374b3308945ea8cb7572 > > > Diff: https://reviews.apache.org/r/63859/diff/3/ > > > Testing > ------- > > See https://reviews.apache.org/r/63862/ for test results. > > > Thanks, > > Akash Gupta > >
