> On Nov. 17, 2017, 2:54 a.m., Avinash sridharan wrote: > > src/checks/tcp_connect.cpp > > Lines 90 (patched) > > <https://reviews.apache.org/r/63795/diff/2/?file=1894182#file1894182line92> > > > > Why do we need this? > > > > `net::IP::in` and `net::IP::in6` already give this functionality we > > should just use those?
We need to call `parse->family()` to know it is `AF_INET` or `AF_INET6`, and then call `net::IP::in()` or `net::IP::in6()` accordingly. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/#review191196 ----------------------------------------------------------- On Nov. 16, 2017, 3:21 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63795/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2017, 3:21 p.m.) > > > Review request for mesos, Alexander Rukletsov and Avinash sridharan. > > > Bugs: MESOS-8050 > https://issues.apache.org/jira/browse/MESOS-8050 > > > Repository: mesos > > > Description > ------- > > Made `mesos-tcp-connect` support IPv6. > > > Diffs > ----- > > src/checks/tcp_connect.cpp 2514f4aebcc634b18cd2b3c36529222fe456e903 > > > Diff: https://reviews.apache.org/r/63795/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
