----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review191409 -----------------------------------------------------------
FAIL: Some Mesos tests failed. Reviews applied: `['61473']` Failed command: `C:\DCOS\mesos\src\mesos-tests.exe --verbose` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61473 Relevant logs: - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61473/logs/mesos-tests-stdout.log): ``` [ OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/0 (299 ms) [ RUN ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/1 [ OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/1 (308 ms) [ RUN ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/2 [ OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/2 (326 ms) [ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/0 [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/0 (394 ms) [ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/1 [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/1 (349 ms) [ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (345 ms) [----------] 9 tests from Endpoint/SlaveEndpointTest (3329 ms total) [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (130 ms) [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (155 ms) [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (342 ms total) [----------] Global test environment tear-down [==========] 759 tests from 79 test cases ran. (477634 ms total) [ PASSED ] 758 tests. [ FAILED ] 1 test, listed below: [ FAILED ] PartitionTest.PartitionAwareTaskCompletedOnPartitionedAgent 1 FAILED TEST YOU HAVE 216 DISABLED TESTS ``` - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61473/logs/mesos-tests-stderr.log): ``` I1117 23:04:09.269928 5696 http.cpp:976] Authorizing principal 'test-principal' to GET the '/monitor/statistics.json' endpoint I1117 23:04:09.302928 3152 slave.cpp:883] Agent terminating I1117 23:04:09.469130 1632 containerizer.cpp:301] Using isolation { windows/cpu, filesystem/windows, environment_secret } I1117 23:04:09.475131 1632 provisioner.cpp:255] Using default backend 'copy' I1117 23:04:09.489130 1632 cluster.cpp:448] Creating default 'local' authorizer I1117 23:04:09.508131 5456 slave.cpp:262] Mesos agent started on (282)@10.3.1.7:54447 I1117 23:04:09.508131 5456 slave.cpp:263] Flags at startup: --acls="" --appc_simple_discovery_uri_prefix="http://" --appc_store_dir="C:\Users\mesos\AppData\Local\Temp\YtIABK\store\appc" --authenticate_http_executors="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticatee="crammd5" --authentication_backoff_factor="1secs" --authorizer="local" --container_disk_watch_interval="15secs" --containerizers="mesos" --credential="C:\Users\mesos\AppData\Local\Temp\YtIABK\credential" --default_role="*" --disk_watch_interval="1mins" --docker="docker" --docker_kill_orphans="true" --docker_registry="https://registry-1.docker.io" --docker_remove_delay="6hrs" --docker_socket="//./pipe/docker_engine" --docker_stop_timeout="0ns" --docker_store_dir="C:\Users\mesos\AppData\Local\Temp\YtIABK\store\docker" --docker_volume_checkpoint_dir="/var/run/mesos/isolators/docker/volume" --enforce_container_disk_quota="false" --executor_registration_timeout="1mins" --executor_r eregistration_timeout="2secs" --executor_secret_key="C:\Users\mesos\AppData\Local\Temp\YtIABK\executor_secret_key" --executor_shutdown_grace_period="5secs" --fetcher_cache_dir="C:\Users\mesos\AppData\Local\Temp\YtIABK\fetch" --fetcher_cache_size="2GB" --frameworks_home="" --gc_delay="1weeks" --gc_disk_headroom="0.1" --hadoop_home="" --help="false" --hostname_lookup="true" --http_command_executor="false" --http_credentials="C:\Users\mesos\AppData\Local\Temp\YtIABK\http_credentials" --http_heartbeat_interval="30secs" --initialize_driver_logging="true" --isolation="windows/cpu" --launcher="windows" --launcher_dir="C:\DCOS\mesos\src" --logbufsecs="0" --logging_level="INFO" --max_completed_executors_per_framework="150" --oversubscribed_resources_interval="15secs" --port="5051" --qos_correction_interval_min="0ns" --quiet="false" --recover="reconnect" --recovery_timeout="15mins" --registration_backoff_factor="10ms" --resources="cpus:2;gpus:0;mem:1024;disk:1024;ports:[31000-32000]" --runtim e_dir="C:\Users\mesos\AppData\Local\Temp\YtIABK" --sandbox_directory="C:\mesos\sandbox" --strict="true" --version="false" --work_dir="C:\Users\mesos\AppData\Local\Temp\It8yra" --zk_session_timeout="10secs" I1117 23:04:09.533133 5456 credentials.hpp:86] Loading credential for authentication from 'C:\Users\mesos\AppData\Local\Temp\YtIABK\credential' I1117 23:04:09.534132 5456 slave.cpp:295] Agent using credential for: test-principal I1117 23:04:09.534132 5456 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\YtIABK\http_credentials' I1117 23:04:09.538131 5456 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-executor' I1117 23:04:09.549134 5456 http.cpp:1066] Creating default 'jwt' HTTP authenticator for realm 'mesos-agent-executor' I1117 23:04:09.550133 5456 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-readonly' I1117 23:04:09.551133 5456 http.cpp:1066] Creating default 'jwt' HTTP authenticator for realm 'mesos-agent-readonly' I1117 23:04:09.552134 5456 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-readwrite' I1117 23:04:09.561786 5456 http.cpp:1066] Creating default 'jwt' HTTP authenticator for realm 'mesos-agent-readwrite' I1117 23:04:09.570133 5456 slave.cpp:593] Agent resources: [{"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}] I1117 23:04:09.574133 5456 slave.cpp:601] Agent attributes: [ ] I1117 23:04:09.623152 5456 slave.cpp:610] Agent hostname: mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net I1117 23:04:09.624136 4048 status_update_manager.cpp:177] Pausing sending status updates I1117 23:04:09.630136 5088 state.cpp:64] Recovering state from 'C:\Users\mesos\AppData\Local\Temp\It8yra\meta' I1117 23:04:09.632138 3224 status_update_manager.cpp:203] Recovering status update manager I1117 23:04:09.633142 1908 containerizer.cpp:662] Recovering containerizer I1117 23:04:09.640139 1732 provisioner.cpp:416] Provisioner recovery complete I1117 23:04:09.641135 4048 slave.cpp:6441] Finished recovery I1117 23:04:09.669137 4048 http.cpp:1185] HTTP GET for /slave(282)/containers from 10.3.1.7:54456 I1117 23:04:09.669137 4048 http.cpp:976] Authorizing principal 'test-principal' to GET the '/containers' endpoint I1117 23:04:09.693140 1632 slave.cpp:883] Agent terminating I1117 23:04:10.458806 5828 process.cpp:1052] Failed to accept socket: future discarded ``` - Mesos Reviewbot Windows On Nov. 17, 2017, 10:35 p.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61473/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 10:35 p.m.) > > > Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-7215 > https://issues.apache.org/jira/browse/MESOS-7215 > > > Repository: mesos > > > Description > ------- > > Master will not kill the tasks for non-Partition aware frameworks > when an unreachable agent re-registers with the master. > Master used to send a ShutdownFrameworkMessages to the agent > to kill the tasks from non partition aware frameworks including the > ones that are still registered which was problematic because the offer > from this agent could still go to the same framework which could then > launch new tasks. The agent would then receive tasks of the same > framework and ignore them because it thinks the framework is shutting > down. The framework is not shutting down of course, so from the master > and the scheduler's perspective the task is pending in STAGING forever > until the next agent reregistration, which could happen much later. > This commit fixes the problem by not shutting down the non-partition > aware frameworks on such an agent. > > > Diffs > ----- > > include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 > include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e > src/master/http.cpp 10084125deb839a9846a4f64d2e433ff02754c02 > src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3 > src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f > src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7 > > > Diff: https://reviews.apache.org/r/61473/diff/17/ > > > Testing > ------- > > make check > > > Thanks, > > Megha Sharma > >