> On Nov. 28, 2017, 12:46 a.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Line 9370 (original), 9322 (patched) > > <https://reviews.apache.org/r/61473/diff/22/?file=1902260#file1902260line9370> > > > > I have the similar feeling as Ilya, without context it's hard to > > understand this line. Although the context is not too far above, why not > > just define it within the context? > > > > > > ``` > > TaskState newTaskState = TASK_UNREACHABLE; > > TaskStatus::Reason newTaskReason = TaskStatus::REASON_SLAVE_REMOVED; > > > > // Needed to convey task unreachablility because we lose this > > information > > // from the task state if `TASK_LOST` is used. > > bool unreachable = true; > > > > if (!framework->capabilities.partitionAware) { > > newTaskState = TASK_LOST; > > } else if (unreachableTime.isNone()) { > > unreachable = false; > > newTaskState = TASK_GONE_BY_OPERATOR; > > newTaskReason = TaskStatus::REASON_SLAVE_REMOVED_BY_OPERATOR; > > } > > ``` > > > > Note that I simplied the nested if else structure. Does it look right? > > Megha Sharma wrote: > Looks good, thanks Yan!
That line is still there :) `unreachable` declared on it shadows the one outside of the loop. - Ilya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review191976 ----------------------------------------------------------- On Nov. 28, 2017, 9:28 a.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61473/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2017, 9:28 a.m.) > > > Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-7215 > https://issues.apache.org/jira/browse/MESOS-7215 > > > Repository: mesos > > > Description > ------- > > Master will not kill the tasks for non-Partition aware frameworks > when an unreachable agent re-registers with the master. > Master used to send a ShutdownFrameworkMessages to the agent > to kill the tasks from non partition aware frameworks including > the ones that are still registered which was problematic because > the offer from this agent could still go to the same framework which > could then launch new tasks. The agent would then receive tasks > of the same framework and ignore them because it thinks the > framework is shutting down. The framework is not shutting down of > course, so from the master and the scheduler's perspective the task > is pending in STAGING forever until the next agent reregistration, > which could happen much later. This commit fixes the problem by > not shutting down the non-partition aware frameworks on such an > agent. > > > Diffs > ----- > > include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 > include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e > src/master/http.cpp 10084125deb839a9846a4f64d2e433ff02754c02 > src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3 > src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f > src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7 > > > Diff: https://reviews.apache.org/r/61473/diff/24/ > > > Testing > ------- > > make check > > > Thanks, > > Megha Sharma > >
