> On Nov. 13, 2017, 10:35 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some Mesos libprocess-tests failed. > > > > Reviews applied: `['63765']` > > > > Failed command: > > `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe` > > > > All the build artifacts available at: > > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63765 > > > > Relevant logs: > > > > - > > [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63765/logs/libprocess-tests-stdout.log): > > > > ``` > > [ OK ] Scheme/HTTPTest.WWWAuthenticateHeader/0 (837 ms) > > [ RUN ] Scheme/HTTPTest.WWWAuthenticateHeader/1 > > [ OK ] Scheme/HTTPTest.WWWAuthenticateHeader/1 (71 ms) > > [ RUN ] Scheme/HTTPTest.Accepts/0 > > [ OK ] Scheme/HTTPTest.Accepts/0 (400 ms) > > [ RUN ] Scheme/HTTPTest.Accepts/1 > > [ OK ] Scheme/HTTPTest.Accepts/1 (95 ms) > > [----------] 34 tests from Scheme/HTTPTest (12856 ms total) > > > > [----------] 4 tests from SSLVerifyIPAdd/SSLTest > > [ RUN ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0 > > [ OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0 (718 ms) > > [ RUN ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1 > > [ OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1 (255 ms) > > [ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0 > > [ OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0 (728 ms) > > [ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 > > [ OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 (1154 ms) > > [----------] 4 tests from SSLVerifyIPAdd/SSLTest (3015 ms total) > > > > [----------] Global test environment tear-down > > [==========] 201 tests from 33 test cases ran. (47658 ms total) > > [ PASSED ] 200 tests. > > [ FAILED ] 1 test, listed below: > > [ FAILED ] SSLTest.SSLSocket > > > > 1 FAILED TEST > > YOU HAVE 19 DISABLED TESTS > > > > ``` > > > > - > > [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63765/logs/libprocess-tests-stderr.log): > > > > ``` > > I1113 22:35:08.356146 388 openssl.cpp:509] CA directory path unspecified! > > NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath> > > I1113 22:35:08.356146 388 openssl.cpp:514] Will not verify peer > > certificate! > > NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peWARNING: Logging before > > InitGoogleLogging() is written to STDERR > > I1113 22:35:08.664160 2056 openssl.cpp:509] CA directory path unspecified! > > NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath> > > I1113 22:35:08.665160 2056 openssl.cpp:514] Will not verify peer > > certificate! > > NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate > > verification > > I1113 22:35:08.665160 2056 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT > > implies peer certificate verification. > > LIBPROCESS_SSL_VERIFY_CERT set to true > > I1113 22:35:08.666160 2056 openssl.cpp:563] Using CA file: > > C:\Users\mesos\AppData\Local\Temp\7tcras\cert.pem > > WARNING: Logging before InitGoogleLogging() is written to STDERR > > I1113 22:35:09.757180 4952 openssl.cpp:509] CA directory path unspecified! > > NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath> > > I1113 22:35:09.759182 4952 openssl.cpp:514] Will not verify peer > > certificate! > > NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate > > verification > > I1113 22:35:09.759182 4952 openssl.cpp:526] Will use IP address > > verification in subject alternative name certificate extension. > > I1113 22:35:09.759182 4952 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT > > implies peer certificate verification. > > LIBPROCESS_SSL_VERIFY_CERT set to true > > I1113 22:35:09.760185 4952 openssl.cpp:563] Using CA file: > > C:\Users\mesos\AppData\Local\Temp\eGNHTo\cert.pem > > er certificate verification > > I1113 22:35:08.368152 388 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT > > implies peer certificate verification. > > LIBPROCESS_SSL_VERIFY_CERT set to true > > I1113 22:35:08.368152 388 openssl.cpp:563] Using CA file: > > C:\Users\mesos\AppData\Local\Temp\7tcras\cert.pem > > I1113 22:35:09.456182 388 openssl.cpp:509] CA directory path unspecified! > > NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath> > > I1113 22:35:09.457181 388 openssl.cpp:514] Will not verify peer > > certificate! > > NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate > > verification > > I1113 22:35:09.457181 388 openssl.cpp:526] Will use IP address > > verification in subject alternative name certificate extension. > > I1113 22:35:09.457181 388 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT > > implies peer certificate verification. > > LIBPROCESS_SSL_VERIFY_CERT set to true > > I1113 22:35:09.457181 388 openssl.cpp:563] Using CA file: > > C:\Users\mesos\AppData\Local\Temp\eGNHTo\cert.pem > > I1113 22:35:10.005447 4220 process.cpp:1052] Failed to accept socket: > > future discarded > > ```
@andrew is this a flaky test? looks unrelated to this change. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63765/#review190897 ----------------------------------------------------------- On Nov. 13, 2017, 9:32 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63765/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2017, 9:32 p.m.) > > > Review request for mesos, Gilbert Song and Vinod Kone. > > > Bugs: MESOS-8171 > https://issues.apache.org/jira/browse/MESOS-8171 > > > Repository: mesos > > > Description > ------- > > When framework failover time is set to zero (which is the > default value), the scheduler driver subscribe backoff time > will also become zero. Ignore failover time if it is zero > when deciding the subscribe backoff time. > Also added a dedicated test. > > > Diffs > ----- > > src/sched/sched.cpp 6028499285ad092ffd252e842c5d9835dd4442f8 > src/tests/scheduler_driver_tests.cpp > 14d872b8fadfd4ef16d8923fb0df924331534bc3 > > > Diff: https://reviews.apache.org/r/63765/diff/1/ > > > Testing > ------- > > make check, and the new dedicated test. > > > Thanks, > > Meng Zhu > >
