----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63765/#review191445 -----------------------------------------------------------
src/tests/scheduler_driver_tests.cpp Line 77 (original), 78 (patched) <https://reviews.apache.org/r/63765/#comment269259> 2 blank lines between outer elements. src/tests/scheduler_driver_tests.cpp Lines 96 (patched) <https://reviews.apache.org/r/63765/#comment269260> we use camel case for our variable names in mesos and snake case in libprocess/stout s/in_sequence/inSequence/ btw, why is the sequence here necessary? src/tests/scheduler_driver_tests.cpp Lines 98 (patched) <https://reviews.apache.org/r/63765/#comment269261> Add a comment here // Drop the first SUBSCRIBE call so that the driver retries. src/tests/scheduler_driver_tests.cpp Lines 113 (patched) <https://reviews.apache.org/r/63765/#comment269263> // Settling the clock ensures that if a retried SUBSCRIBE call is enqueue it // will be processed. Since the backoff is non-zero no new SUBSCRIBE call // should be sent when the clock is paused. src/tests/scheduler_driver_tests.cpp Line 78 (original), 118 (patched) <https://reviews.apache.org/r/63765/#comment269264> 2 blank lines between out elements. - Vinod Kone On Nov. 13, 2017, 9:32 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63765/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2017, 9:32 p.m.) > > > Review request for mesos, Gilbert Song and Vinod Kone. > > > Bugs: MESOS-8171 > https://issues.apache.org/jira/browse/MESOS-8171 > > > Repository: mesos > > > Description > ------- > > When framework failover time is set to zero (which is the > default value), the scheduler driver subscribe backoff time > will also become zero. Ignore failover time if it is zero > when deciding the subscribe backoff time. > Also added a dedicated test. > > > Diffs > ----- > > src/sched/sched.cpp 6028499285ad092ffd252e842c5d9835dd4442f8 > src/tests/scheduler_driver_tests.cpp > 14d872b8fadfd4ef16d8923fb0df924331534bc3 > > > Diff: https://reviews.apache.org/r/63765/diff/1/ > > > Testing > ------- > > make check, and the new dedicated test. > > > Thanks, > > Meng Zhu > >
