----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63831/#review191613 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp Lines 430-437 (original), 431-438 (patched) <https://reviews.apache.org/r/63831/#comment269456> Do we need a lambda here? src/tests/scheduler_tests.cpp Lines 1554-1556 (patched) <https://reviews.apache.org/r/63831/#comment269460> How about something like this: // This test verifies that if a framework decides to suppress its roles on reregisteration, no offers will be made. - Alexander Rukletsov On Nov. 16, 2017, 7:05 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63831/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2017, 7:05 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-8223 > https://issues.apache.org/jira/browse/MESOS-8223 > > > Repository: mesos > > > Description > ------- > > In `updateFramework`, we currently treat frameworks suppressing a role the > same way as frameworks moving off a role and this could lead to the framework > being removed from the framework sorter, which is unexpected. We should only > remove the framework from a framework sorter when it's moving away from the > corresponding role. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > f0f1111a7754e5968288edb15929efc9d244b177 > src/tests/scheduler_tests.cpp 45fc9c0cfccdb22c2e3e8d5de30c04575814a0e9 > > > Diff: https://reviews.apache.org/r/63831/diff/1/ > > > Testing > ------- > > make check. > > Added a test. > > > Thanks, > > Jiang Yan Xu > >
