-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63831/
-----------------------------------------------------------
(Updated Nov. 27, 2017, 4:45 p.m.)
Review request for mesos and Alexander Rukletsov.
Changes
-------
Addressed comments.
Bugs: MESOS-8223
https://issues.apache.org/jira/browse/MESOS-8223
Repository: mesos
Description
-------
In `updateFramework`, we currently treat frameworks suppressing a role the same
way as frameworks moving off a role and this could lead to the framework being
removed from the framework sorter, which is unexpected. We should only remove
the framework from a framework sorter when it's moving away from the
corresponding role.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp
5ce9ceaa3a5f84a1e076d45448863c418531cc2b
src/tests/scheduler_tests.cpp 45fc9c0cfccdb22c2e3e8d5de30c04575814a0e9
Diff: https://reviews.apache.org/r/63831/diff/2/
Changes: https://reviews.apache.org/r/63831/diff/1-2/
Testing
-------
make check.
Added a test.
Thanks,
Jiang Yan Xu
