> On Nov. 22, 2017, 8:40 a.m., Alexander Rojas wrote: > > There are no tests anywhere in the chain. I disapprove of code written > > without unit tests. Please address that in the whole chain.
Will do. Need more time to add more tests :( - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62636/#review191708 ----------------------------------------------------------- On Nov. 21, 2017, 12:10 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62636/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 12:10 a.m.) > > > Review request for mesos, Alexander Rojas, Greg Mann, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-8100 > https://issues.apache.org/jira/browse/MESOS-8100 > > > Repository: mesos > > > Description > ------- > > `LocalResourceProviderDaemon` now uses `Slave::secretGenerater` to > generate an authentication token for each local resource provider. The > authentication token can then be used to call the V1 agent API. In order > to generate the tokens, `LocalResourceProviderDaemon::load()` is now an > asynchronous function. > > > Diffs > ----- > > src/resource_provider/daemon.hpp ef6c356cb6ddb2594d767d7dd6052e9fd8df8263 > src/resource_provider/daemon.cpp d584eb9d7aa75522aec97277674321061b90fbed > src/resource_provider/local.hpp ebaa07d03ad77d516066ee2d4b60864be0611b5f > src/resource_provider/local.cpp ad98f333c5668ca81de6e7ed3fc8f59323b151da > src/resource_provider/storage/provider.hpp > 6de88c2329b358fcf48bc39ddda0132170991c3c > src/resource_provider/storage/provider.cpp > 46224997430ac0c568904d80014166a6f059907f > src/slave/slave.cpp d8edc5e6bbfa265bca4d19bbaa7db3063949dbc0 > > > Diff: https://reviews.apache.org/r/62636/diff/8/ > > > Testing > ------- > > make > > > Thanks, > > Chun-Hung Hsiao > >
