----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63377/#review191821 -----------------------------------------------------------
Fix it, then Ship it! src/csi/paths.cpp Lines 149 (patched) <https://reviews.apache.org/r/63377/#comment269746> Can you add a comment about why you want to do that (checking socket path length)? It not quite obvious from the code. - Jie Yu On Nov. 21, 2017, 5:36 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63377/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 5:36 a.m.) > > > Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht. > > > Bugs: MESOS-8141 > https://issues.apache.org/jira/browse/MESOS-8141 > > > Repository: mesos > > > Description > ------- > > A CSI plugin can now store the following persistent CSI > data in `<work_dir>/csi/<type>/<name>/`: > > 1. Mount points of CSI volumes: `volumes/<volume_id>` > 2. States of CSI volumes: `states/<volume_id>/state` > 3. Directory to place CSI endpoints: `/tmp/mesos-csi-XXXXXX`, which > would be symlinked by `containers/<container_id>/endpoint`. > > > Diffs > ----- > > src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8 > src/csi/paths.hpp PRE-CREATION > src/csi/paths.cpp PRE-CREATION > src/slave/paths.hpp 66dfa4544772d78ccc9229dc861da60c79913f24 > src/slave/paths.cpp b03ffeeed83cb73228cca27769262fb08df38fb5 > > > Diff: https://reviews.apache.org/r/63377/diff/3/ > > > Testing > ------- > > make > > > Thanks, > > Chun-Hung Hsiao > >
