> On Nov. 28, 2017, 3:28 a.m., Jie Yu wrote: > > src/resource_provider/manager.cpp > > Lines 389 (patched) > > <https://reviews.apache.org/r/64065/diff/2/?file=1901743#file1901743line393> > > > > I don't like the pointer way neither. Especially the fact that it might > > point to a stack object. > > > > Give that you need to access provider ID below anyway, I prefer we just > > save provider ID and do a lookup later.
Yes, changed it like that. Never liked that reference/pointer here as well. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64065/#review191974 ----------------------------------------------------------- On Nov. 28, 2017, 12:17 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64065/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2017, 12:17 p.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > A resource provider can resubscribe by including the resource provider > ID it got assigned as part of its 'ResourceProviderInfo' in a > 'SUBSCRIBE' call. A resubscription is necessary if either the resource > provider or the resource provider manager (i.e. an agent) failed over. > > > Diffs > ----- > > src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00 > src/tests/mesos.hpp e5c2b697a4401f010a7d77ae9acb8a9cbd3846bc > src/tests/resource_provider_manager_tests.cpp > 0b7c4ad6bb0052847b884959e3171cd7ab382b45 > src/tests/slave_tests.cpp a2274b691cf94b003c4bc15450d176a9c73517d5 > > > Diff: https://reviews.apache.org/r/64065/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
