----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64054/#review192026 -----------------------------------------------------------
src/master/master.cpp Line 10867 (original), 10879 (patched) <https://reviews.apache.org/r/64054/#comment270012> We should only count non-terminal operations here. Could you update the condition? - Benjamin Bannier On Nov. 28, 2017, 11:42 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64054/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2017, 11:42 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Applying operations has been refactored out of 'addOfferOperation' and > simplified by using 'protobuf::isSpeculativeOperation'. > > > Diffs > ----- > > src/master/master.cpp 53263e499d88b906b6406c24c0dfb737e589e813 > src/slave/slave.cpp 6ed5c7887cf998b92cf3181b29cb6cf09cc73e61 > > > Diff: https://reviews.apache.org/r/64054/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
