> On Nov. 29, 2017, 1:11 a.m., Chun-Hung Hsiao wrote: > > src/slave/main.cpp > > Lines 566 (patched) > > <https://reviews.apache.org/r/64132/diff/1/?file=1902723#file1902723line566> > > > > One line apart here.
I think i did that in the next patch > On Nov. 29, 2017, 1:11 a.m., Chun-Hung Hsiao wrote: > > src/tests/cluster.cpp > > Lines 545 (patched) > > <https://reviews.apache.org/r/64132/diff/1/?file=1902727#file1902727line545> > > > > Is it allowed to reset an `Owned` or a `shared_ptr` to `nullptr`? Yes. > On Nov. 29, 2017, 1:11 a.m., Chun-Hung Hsiao wrote: > > src/tests/mesos.hpp > > Lines 254 (patched) > > <https://reviews.apache.org/r/64132/diff/1/?file=1902728#file1902728line254> > > > > Why are we having an `Option<Authorizer*>` here with a default value, > > but not in the functions above? Because i don't want to create two overloads (w/ and w/o authorizer). This part needs a refactor anyway. See the TODO by bmahler. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64132/#review192084 ----------------------------------------------------------- On Nov. 28, 2017, 8:33 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64132/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2017, 8:33 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Allowed the injection of secret generator into the Slave. > > > Diffs > ----- > > src/local/local.cpp 2e141c608086ea04ccb681b085c66b799bbbafb2 > src/slave/main.cpp f0716fb90f0b6521dd85e2094dbcdb8621105ea9 > src/slave/slave.hpp d538a8baf970b9e127fc8c14a9e300fb2dd58a93 > src/slave/slave.cpp cd716476dfad619dc6cf7449a32a27842efbe7fb > src/tests/cluster.hpp d572a09ea57bf05e04b6df8b2c343a4fb508caef > src/tests/cluster.cpp b8549045e4555e736434f77a837c2c955b599f0a > src/tests/mesos.hpp f02c7c6962c9d0bee57712d8aad9997582c7404b > src/tests/mesos.cpp 9185b5bf2175be5b0f6b6a03a04e9e5445bf22fd > src/tests/mock_slave.hpp 7c4d43a4133e2edb9fdb8da399f8c462104466cd > src/tests/mock_slave.cpp 90c4369ec395a899539822a69d73716b1ec2c489 > src/tests/slave_authorization_tests.cpp > 11fd0d4e35523eca23a9603ecef0c9d0b65dde38 > src/tests/slave_tests.cpp a2274b691cf94b003c4bc15450d176a9c73517d5 > > > Diff: https://reviews.apache.org/r/64132/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
