----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64250/#review192563 -----------------------------------------------------------
Fix it, then Ship it! docs/task-state-reasons.md Lines 476 (patched) <https://reviews.apache.org/r/64250/#comment270801> What is the `/written` part about? `overwritten` covers all cases? docs/task-state-reasons.md Lines 477 (patched) <https://reviews.apache.org/r/64250/#comment270805> Given the discussion in /r/64098/, here perhaps add another `Note: Due to garbage collection of the unreachable and gone agents in the registry, Mesos also sends such status updates for agents unknown to the master`. docs/task-state-reasons.md Lines 478 (patched) <https://reviews.apache.org/r/64250/#comment270804> Should there be a `</td></tr>`? Also when it involves doc changes, could you in the testing done section mention that you have used a markdown viewer to review the doc change? - Jiang Yan Xu On Dec. 1, 2017, 1:06 p.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64250/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 1:06 p.m.) > > > Review request for mesos, Ilya Pronin, James Peach, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Added new reasons `REASON_SLAVE_REREGISTERED` and > `REASON_AGENT_REREGISTERED` for v0 and v1 task status update. > The new reason will be used when master starts to send status > update during the re-registeration of an agent which was > previosuly removed by the master because of being unreachable. > > > Diffs > ----- > > docs/task-state-reasons.md 07f7927e28fe5624a6c9b74de731483aaa729ca3 > include/mesos/mesos.proto 11089b7d6f48f001ae64e8b0c67a2732684aa2fa > include/mesos/v1/mesos.proto c496da927903f472c78d455b7fdf886d8fb692c4 > > > Diff: https://reviews.apache.org/r/64250/diff/2/ > > > Testing > ------- > > with make check > > > Thanks, > > Megha Sharma > >
