----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64250/#review192567 -----------------------------------------------------------
Looks good. I just have a small suggestion about the doc. docs/task-state-reasons.md Lines 474-477 (patched) <https://reviews.apache.org/r/64250/#comment270811> I don't quite follow this note. A modified copy of which update? Should we just say that these updates reflect the states of the tasks reported by the agent upon its re-registration? - Ilya Pronin On Dec. 1, 2017, 1:06 p.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64250/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 1:06 p.m.) > > > Review request for mesos, Ilya Pronin, James Peach, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Added new reasons `REASON_SLAVE_REREGISTERED` and > `REASON_AGENT_REREGISTERED` for v0 and v1 task status update. > The new reason will be used when master starts to send status > update during the re-registeration of an agent which was > previosuly removed by the master because of being unreachable. > > > Diffs > ----- > > docs/task-state-reasons.md 07f7927e28fe5624a6c9b74de731483aaa729ca3 > include/mesos/mesos.proto 11089b7d6f48f001ae64e8b0c67a2732684aa2fa > include/mesos/v1/mesos.proto c496da927903f472c78d455b7fdf886d8fb692c4 > > > Diff: https://reviews.apache.org/r/64250/diff/2/ > > > Testing > ------- > > with make check > > > Thanks, > > Megha Sharma > >
