----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64266/#review192618 -----------------------------------------------------------
Fix it, then Ship it! docs/configuration/agent.md Lines 882 (patched) <https://reviews.apache.org/r/64266/#comment270880> Since it can be a file or a string, I would suggest to change it from `JSON-formatted config file` to `JSON-formatted configuration`. And do we want to mention it can only work with Mesos containerizer? docs/configuration/agent.md Lines 886 (patched) <https://reviews.apache.org/r/64266/#comment270881> s/image auto gc/auto image gc/ docs/configuration/agent.md Lines 889 (patched) <https://reviews.apache.org/r/64266/#comment270882> s/details/the expected format/ src/slave/flags.cpp Lines 159-166 (patched) <https://reviews.apache.org/r/64266/#comment270884> Ditto for my comments in agent.md. - Qian Zhang On Dec. 2, 2017, 9:10 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64266/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2017, 9:10 a.m.) > > > Review request for mesos, Jie Yu, Qian Zhang, Vinod Kone, and Zhitao Li. > > > Bugs: MESOS-8294 > https://issues.apache.org/jira/browse/MESOS-8294 > > > Repository: mesos > > > Description > ------- > > This is an optional agent flag. If it is not set, it means > the automatic container image gc is not enabled. Users have > to trigger image gc manually via the operator API. If it is > set, the image auto gc is enabled. > > > Diffs > ----- > > docs/configuration/agent.md f1e0681be34d194d66e2b2ecd3f76653a54068e2 > src/messages/flags.hpp 00e26cd2699a3da9722170324b5c0190850405da > src/slave/flags.hpp 0c02b49c054ef2597298aefe0997beacfc9efeb8 > src/slave/flags.cpp 0eeecdc6023443a99c8e8fe29c2f7bf791c0a36e > > > Diff: https://reviews.apache.org/r/64266/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
