----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64265/#review192619 -----------------------------------------------------------
Fix it, then Ship it! src/messages/flags.proto Lines 112-114 (patched) <https://reviews.apache.org/r/64265/#comment270883> Can we add comments to describe each of the fields? - Qian Zhang On Dec. 2, 2017, 9:10 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64265/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2017, 9:10 a.m.) > > > Review request for mesos, Jie Yu, Qian Zhang, Vinod Kone, and Zhitao Li. > > > Bugs: MESOS-8294 > https://issues.apache.org/jira/browse/MESOS-8294 > > > Repository: mesos > > > Description > ------- > > Added a flag conversion protobuf message 'ImageGcConfig'. > > > Diffs > ----- > > src/messages/flags.proto 7ae9ef82cf9e918cac1eadc9f3ec0534ad4922b2 > > > Diff: https://reviews.apache.org/r/64265/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
