> On Nov. 30, 2017, 10:51 p.m., Jie Yu wrote: > > src/common/protobuf_utils.hpp > > Lines 156 (patched) > > <https://reviews.apache.org/r/64144/diff/1/?file=1903836#file1903836line156> > > > > We typically does not have helper to create internal message (between > > agent/master). > > > > I suggest we just inline this
Good call; done. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64144/#review192378 ----------------------------------------------------------- On Dec. 4, 2017, 10:22 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64144/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2017, 10:22 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan > Schlicht. > > > Bugs: MESOS-8193 > https://issues.apache.org/jira/browse/MESOS-8193 > > > Repository: mesos > > > Description > ------- > > When a framework does not request feedback about an operation, > the master should acknowledge offer operation status updates > to the agent so that the updates are not retried. > > > Diffs > ----- > > src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4 > > > Diff: https://reviews.apache.org/r/64144/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
