----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64144/#review192378 -----------------------------------------------------------
src/common/protobuf_utils.hpp Lines 156 (patched) <https://reviews.apache.org/r/64144/#comment270478> We typically does not have helper to create internal message (between agent/master). I suggest we just inline this src/master/master.cpp Lines 7489-7490 (original), 7489-7494 (patched) <https://reviews.apache.org/r/64144/#comment270494> With reliable status update and ack in mind, i don't think we can remove the offfer operation in master if it's `latest_status` is terminal. There might be a queue of pending status update that hasn't been acked. Instead, we should look at the last received status (i.e., operation->statuses(latest)) and check if that's terminal. src/master/master.cpp Line 7490 (original), 7490 (patched) <https://reviews.apache.org/r/64144/#comment270495> Maybe make that a CHECK for now? - Jie Yu On Nov. 29, 2017, 5:47 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64144/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2017, 5:47 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan > Schlicht. > > > Bugs: MESOS-8193 > https://issues.apache.org/jira/browse/MESOS-8193 > > > Repository: mesos > > > Description > ------- > > When a framework does not request feedback about an operation, > the master should acknowledge offer operation status updates > to the agent so that the updates are not retried. > > > Diffs > ----- > > src/common/protobuf_utils.hpp 6f991e86e46512d5a2bc4e67e160189fccb77f6a > src/common/protobuf_utils.cpp c0ff306ae6c16cbba6fd08469b639b9f906c672b > src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 > > > Diff: https://reviews.apache.org/r/64144/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >