----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/#review192806 -----------------------------------------------------------
src/resource_provider/storage/provider.cpp Lines 439 (patched) <https://reviews.apache.org/r/63022/#comment271099> Please don't use `*` for default profile. src/resource_provider/storage/provider.cpp Lines 654 (patched) <https://reviews.apache.org/r/63022/#comment271097> typo src/resource_provider/storage/provider.cpp Lines 670-714 (patched) <https://reviews.apache.org/r/63022/#comment271098> Can you combine these two loops. Let's not worried about the case where resources disappear. We need to handle that in the future using maintainance primitives maybe. src/resource_provider/storage/provider.cpp Lines 766 (patched) <https://reviews.apache.org/r/63022/#comment271096> Can you add a TODO to do the reconciliation early. src/resource_provider/storage/provider.cpp Lines 1207 (patched) <https://reviews.apache.org/r/63022/#comment271095> Let's not use `*` to indicate a default profile. Please just not set the profile field. - Jie Yu On Dec. 5, 2017, 2:18 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63022/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2017, 2:18 a.m.) > > > Review request for mesos, James DeFelice, Jie Yu, Joseph Wu, and Jan Schlicht. > > > Bugs: MESOS-8101 > https://issues.apache.org/jira/browse/MESOS-8101 > > > Repository: mesos > > > Description > ------- > > The following lists the steps to reconcile resources: > > 1. Import resources from the CSI plugin: > a. Get preprovisioned volumes: > ListVolumes > ValidateVolumeCapabilities for each volume > b. GetCapacity for each profile to get RAW resources > 2. For each resource in the checkpointed resources: > a. Strip away metadata for offer operations > b. Keep the persistent volumes and all resources contained in the > imported resources > c. Additional imported resources are new resources > 3. Report the reconciled resources through UPDATE_STATE > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > d35b0d02992e3730ca47906b34c21e1ba9c653e7 > > > Diff: https://reviews.apache.org/r/63022/diff/15/ > > > Testing > ------- > > > Thanks, > > Chun-Hung Hsiao > >