----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/#review194088 -----------------------------------------------------------
What about the fix for other built-in executors (docker, default)? Also, this only seems to fix the shutdown path, what about kill task path? Regaring the fix for kill task when a task hasn't been launched from the perspective of the executor, I think doing a CHECK fail makes sense to me because there was violation of an external variant (kill comes after launch). Silently shutting down in such a scenario seems risky because it will mask the extent of the problem. Either way we need the system to heal and correct itself when variants fail; right now the executor ignores the kill and stays up which is a really bad UX. cc @anand - Vinod Kone On Dec. 15, 2017, 10:43 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64069/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2017, 10:43 a.m.) > > > Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5 > > > Diff: https://reviews.apache.org/r/64069/diff/1/ > > > Testing > ------- > > See https://reviews.apache.org/r/64033/ > > > Thanks, > > Alexander Rukletsov > >
