----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64810/#review194440 -----------------------------------------------------------
Ship it! Ship It! - Alexander Rukletsov On Dec. 22, 2017, 3:21 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64810/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2017, 3:21 p.m.) > > > Review request for mesos, Alexander Rukletsov, Armand Grillet, and Ilya > Pronin. > > > Repository: mesos > > > Description > ------- > > The clang version on e.g., ubuntu16 would emit a diagnostic message > for the increment inside the expectation, > > ../../src/tests/log_tests.cpp:2439:120: \ > error: expression with side effects has no effect > > We reorder expressions to avoid above situation. > > > Diffs > ----- > > src/tests/log_tests.cpp 5dcb693928cc68ab135af5e289fe33a80cf2e69a > > > Diff: https://reviews.apache.org/r/64810/diff/1/ > > > Testing > ------- > > `make check`, ubuntu16 w/ clang. > > > Thanks, > > Benjamin Bannier > >
