> On Jan. 9, 2018, 6:14 p.m., Till Toenshoff wrote: > > src/examples/test_csi_user_framework.cpp > > Line 432 (original), 428 (patched) > > <https://reviews.apache.org/r/65042/diff/1/?file=1936344#file1936344line449> > > > > Used the wrong constructor here - this won't authenticate.
Even worse, the credentials passed to the constructor weren't even used. Fixed both issues. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/#review195044 ----------------------------------------------------------- On Jan. 9, 2018, 7:01 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65042/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2018, 7:01 p.m.) > > > Review request for mesos, Gaston Kleiman and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > This patch adjusts the CSI example framework for recent cleanups to > example frameworks. It now uses generic flag classes which can e.g., > parse from both the environment and the command line. > > > Diffs > ----- > > src/examples/test_csi_user_framework.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65042/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
