----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/#review195078 -----------------------------------------------------------
src/examples/test_csi_user_framework.cpp Line 93 (original), 91 (patched) <https://reviews.apache.org/r/65042/#comment274215> This parameter should be named `_credential`. src/examples/test_csi_user_framework.cpp Line 94 (original), 92 (patched) <https://reviews.apache.org/r/65042/#comment274216> You need to add `credential(_credential)` to the initialization list. src/examples/test_csi_user_framework.cpp Lines 422-432 (patched) <https://reviews.apache.org/r/65042/#comment274217> It is not very clear to me why we need this block. Do we set `MESOS_AUTHENTICATE_HTTP_FRAMEWORKS` and `MESOS_HTTP_FRAMEWORK_AUTHENTICATORS` so that the scheduler driver knows how to authenticate with the local master? Why do we set `MESOS_ACLS`? The scheduler driver doesn't seem to use it. - Gaston Kleiman On Jan. 9, 2018, 10:01 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65042/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2018, 10:01 a.m.) > > > Review request for mesos, Gaston Kleiman and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > This patch adjusts the CSI example framework for recent cleanups to > example frameworks. It now uses generic flag classes which can e.g., > parse from both the environment and the command line. > > > Diffs > ----- > > src/examples/test_csi_user_framework.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65042/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
