----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review196152 -----------------------------------------------------------
src/master/http.cpp Lines 741-742 (patched) <https://reviews.apache.org/r/65044/#comment275661> The case statements here seem to follow the order of the `Call.type` enum, so I'd move this block to line 734 (above `GET_TASKS`). src/master/http.cpp Line 3933 (original), 3961 (patched) <https://reviews.apache.org/r/65044/#comment275662> Shouldn't we add a similar method: `Master:Http:OPERATIONS_HELP()`? src/master/validation.cpp Lines 133-134 (patched) <https://reviews.apache.org/r/65044/#comment275666> Ditto, move this above `GET_TASKS`. - Gaston Kleiman On Jan. 24, 2018, 1:36 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65044/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2018, 1:36 a.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and > Jie Yu. > > > Bugs: MESOS-8424 > https://issues.apache.org/jira/browse/MESOS-8424 > > > Repository: mesos > > > Description > ------- > > The 'GET_OPERATIONS' call lists all operations known to master or agent. > > > Diffs > ----- > > include/mesos/agent/agent.proto 315820041990d28e5cdae71c8385d4551d56558c > include/mesos/master/master.proto 3e34634f3b864222d07374936c0d9a18269c2fbd > include/mesos/v1/agent/agent.proto 9e8b49defb83ffd4dd240ebb3a09b2dd3610ab2a > include/mesos/v1/master/master.proto > 6759c3004e7e04c0044360b0c54f4438c2f6ec8a > src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 > src/master/master.hpp b434d2398b8815811345b6586ca586d2025cb2a2 > src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 > src/slave/http.hpp 1619bb77e3e7d5a6d387e4d4bb071d83ce914967 > src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a > src/slave/validation.cpp 0c2ccda177734cf3c47c0346ed34d20d58e7d932 > src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 > > > Diff: https://reviews.apache.org/r/65044/diff/7/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >